Discussion:
About the completion feature ported from glade 3.8
Marco Diego Aurélio Mesquita
2012-03-12 20:28:29 UTC
Permalink
Hi Devs!

I do know you receive bugmail but, since it is hard to find you in the
IRC channel, I decided to send this mail.

We're close to gnome 3.4 launch and I really would like the patch in
https://bugzilla.gnome.org/show_bug.cgi?id=667570 to be committed. Can
it be rushed? Is there anything I have to do to get this change in
master?
_______________________________________________
Glade-devel maillist - Glade-***@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/glade-devel
Juan Pablo Ugarte
2012-03-14 23:01:57 UTC
Permalink
Post by Marco Diego Aurélio Mesquita
Hi Devs!
I do know you receive bugmail but, since it is hard to find you in the
IRC channel, I decided to send this mail.
We're close to gnome 3.4 launch and I really would like the patch in
https://bugzilla.gnome.org/show_bug.cgi?id=667570 to be committed. Can
it be rushed? Is there anything I have to do to get this change in
master?
We are already in UI freeze so I do not think we can include it.

greets

JP

_______________________________________________
Glade-devel maillist - Glade-***@lists.ximian.com
http://lists.ximi
Tristan Van Berkom
2012-03-15 10:54:40 UTC
Permalink
Post by Juan Pablo Ugarte
Post by Marco Diego Aurélio Mesquita
Hi Devs!
I do know you receive bugmail but, since it is hard to find you in the
IRC channel, I decided to send this mail.
We're close to gnome 3.4 launch and I really would like the patch in
https://bugzilla.gnome.org/show_bug.cgi?id=667570 to be committed. Can
it be rushed? Is there anything I have to do to get this change in
master?
We are already in UI freeze so I do not think we can include it.
Juan, great to know that you are on top of this.

Will you make us a release of 3.12 with current master ?

Besides the awesome new features that you added in the workspace
there is some widgets we left out (GtkInfoBar is only in master and not
in 3.10 for example).

Also, we should land Denis's GBinding patch first thing in the next
developement cycle. I'm not sure if you merged that in but we
can *not* release 3.12 with the GBindings because it depends
on the GtkBuilder patch that is not landed yet.

Poke me if you need me, I'll hopefully be around more often
in the next cycle but I plan to at least help out with this GBinding
stuff and make sure we land the GtkBuilder patches in GTK+
that we require to move forward with that.

Cheers,
-Tristan
_______________________________________________
Glade-devel maillist - Glade-***@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/glade-devel
Juan Pablo Ugarte
2012-03-19 22:46:59 UTC
Permalink
Post by Tristan Van Berkom
Post by Marco Diego Aurélio Mesquita
Hi Devs!
I do know you receive bugmail but, since it is hard to find you in the
IRC channel, I decided to send this mail.
We're close to gnome 3.4 launch and I really would like the patch in
https://bugzilla.gnome.org/show_bug.cgi?id=667570 to be committed. Can
it be rushed? Is there anything I have to do to get this change in
master?
Ok, so i did not applied the patch as is, instead of having a function
to set a list store which is an implementation detail. I added a new
signal

gchar ** (* callback_suggestions) (GladeSignalEditor *editor,
GladeSignal *signal);
You need to return a null terminated array of string.
This will allow frontends to define anything they want.

hmm I forgot to test the accumulator :S
Post by Tristan Van Berkom
Juan, great to know that you are on top of this.
Will you make us a release of 3.12 with current master ?
yes, I already create a branch for 3.12
Post by Tristan Van Berkom
Besides the awesome new features that you added in the workspace
there is some widgets we left out (GtkInfoBar is only in master and not
in 3.10 for example).
Also, we should land Denis's GBinding patch first thing in the next
developement cycle. I'm not sure if you merged that in but we
can *not* release 3.12 with the GBindings because it depends
on the GtkBuilder patch that is not landed yet.
I will merge it, unless not having the patched gtk breaks the build
Post by Tristan Van Berkom
Poke me if you need me, I'll hopefully be around more often
in the next cycle but I plan to at least help out with this GBinding
stuff and make sure we land the GtkBuilder patches in GTK+
that we require to move forward with that.
Ok great, I will need someone to review the gtk patch :)
Post by Tristan Van Berkom
Cheers,
-Tristan
_______________________________________________
Glade-devel maillist - Glade-***@lists.ximian.com
http://lists.

Marco Diego Aurélio Mesquita
2012-03-15 11:19:25 UTC
Permalink
On Wed, Mar 14, 2012 at 8:01 PM, Juan Pablo Ugarte
Post by Juan Pablo Ugarte
Post by Marco Diego Aurélio Mesquita
Hi Devs!
I do know you receive bugmail but, since it is hard to find you in the
IRC channel, I decided to send this mail.
We're close to gnome 3.4 launch and I really would like the patch in
https://bugzilla.gnome.org/show_bug.cgi?id=667570 to be committed. Can
it be rushed? Is there anything I have to do to get this change in
master?
We are already in UI freeze so I do not think we can include it.
I thought this change would not be qualified as an UI change.
_______________________________________________
Glade-devel maillist - Glade-***@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/glade-devel
Tristan Van Berkom
2012-03-15 12:41:23 UTC
Permalink
Post by Marco Diego Aurélio Mesquita
On Wed, Mar 14, 2012 at 8:01 PM, Juan Pablo Ugarte
Post by Juan Pablo Ugarte
Post by Marco Diego Aurélio Mesquita
Hi Devs!
I do know you receive bugmail but, since it is hard to find you in the
IRC channel, I decided to send this mail.
We're close to gnome 3.4 launch and I really would like the patch in
https://bugzilla.gnome.org/show_bug.cgi?id=667570 to be committed. Can
it be rushed? Is there anything I have to do to get this change in
master?
We are already in UI freeze so I do not think we can include it.
I thought this change would not be qualified as an UI change.
I dont think this is a string or UI change either, the feature is ported
from 3.8 and the added strings are function names, not translatable.

I'm ok with applying the patch after the documentation fixes I mentioned
on the bug, careful to not mark the pspec nick & description as translatable
at least for now, that will avoid a string break.

Cheers,
-Tristan
_______________________________________________
Glade-devel maillist - Glade-***@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/glade-devel
Marco Diego Aurélio Mesquita
2012-03-15 12:56:48 UTC
Permalink
On Thu, Mar 15, 2012 at 9:41 AM, Tristan Van Berkom
Post by Tristan Van Berkom
I'm ok with applying the patch after the documentation fixes I mentioned
on the bug, careful to not mark the pspec nick & description as translatable
at least for now, that will avoid a string break.
Thanks for the support Tristan. I've already updated and sent the
patch. I've been working in the glade-anjuta integration recently and
this feature is the last one missing in my list for this cycle. I'd
really like to get this one in.

Thanks!
_______________________________________________
Glade-devel maillist - Glade-***@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/glade-devel
Marco Diego Aurélio Mesquita
2012-03-16 12:14:53 UTC
Permalink
Hi!

In my timezone we're on Friday and the weekend is coming. March 19
(about 2 days from now) is the gnome hard code freeze deadline. I'll
probably stay off-line until March 20. So Juan, if you agree, since me
and Tristan agree that the feature is "committable" the way it is now,
I'd really really like to have it merged for this cycle.

Thanks!
_______________________________________________
Glade-devel maillist - Glade-***@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/glade-devel
Juan Pablo
2012-03-16 15:45:05 UTC
Permalink
Yeah do not worry i will commit it, but first I want to make sure it does not break API freeze.
Post by Marco Diego Aurélio Mesquita
Hi!
In my timezone we're on Friday and the weekend is coming. March 19
(about 2 days from now) is the gnome hard code freeze deadline. I'll
probably stay off-line until March 20. So Juan, if you agree, since me
and Tristan agree that the feature is "committable" the way it is now,
I'd really really like to have it merged for this cycle.
Thanks!
_______________________________________________
Glade-devel maillist - Glade-***@lists.ximian.com
http://lists.ximia
Loading...